Lamps/password policy #169
Conversation
| @@ -0,0 +1,69 @@ | |||
| module Nexpose | |||
| require 'json' | |||
There was a problem hiding this comment.
This is not needed here. As lib/nexpose.rb takes care of it.
There was a problem hiding this comment.
I disagree. It's good practice to require anything used within the same file. We don't do it much in the gem today, but if we moved to it we could start doing things like lazy loading files.
It's a matter of debate, but it's perfectly harmless to leave since it will only do the work once.
|
There should be a method to list policies as well. |
| module Nexpose | ||
| require 'json' | ||
| # Configuration structure for password policies. | ||
| class Password_policy < APIObject |
There was a problem hiding this comment.
looking at the file name - the name of the class should be PasswordPolicy.
|
@adevitt-r7 Stylistic note — we should be consistently using |
| attr_accessor :digits | ||
| attr_accessor :specialChars | ||
|
|
||
| def initialize(policyName:, minLength:, maxLength:, specialChars:, capitals:, digits:) |
There was a problem hiding this comment.
let's refactor all the attrs, and method arguments to use snake_case instead of camelCase
There was a problem hiding this comment.
I'd leave #to_h since it is used for the #to_json conversion. We'd want to use the same keys there.
| uri = '/api/2.1/password_policy/' | ||
| resp = AJAX.get(nsc, uri, AJAX::CONTENT_TYPE::JSON) | ||
| hash = JSON.parse(resp, symbolize_names: true) | ||
| from_hash(hash) |
There was a problem hiding this comment.
@adevitt-r7 this needs to be self.from_hash
There was a problem hiding this comment.
@sgreen-r7 @adevitt-r7 Oops, merged before seeing this addressed missing there was still an open comment (the other two open comments are opinions).
There was a problem hiding this comment.
@adevitt-r7 Fixed by 86b9010 (from @sgreen-r7).
|
@adevitt-r7 awesome, let's |
. When should this get merged down?
|
@erran-r7 Password policies are going with Odin |
GEM changes required for NEX-43065: [Password Policy Administration] Customized Password Policies.