Merging Staging/v1 into Master #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifying the save method to submit requests to the 2.1 RESTful endpoints. Also renaming public member variables to better reflect the type of data that they will contain.
…methods. The scan target methods were simplified. Also, the methods were modified to support not only string parameters but also IPRange objects for IP addresses and HostName objects for hostnames. Implemented to_hash and from_hash methods to convert the scan targets between strings and their HostName/IPRange objects.
… for discovery connection
Remove Global and Site blackout from gem.
| # | ||
| # @param [HTTPRequest] request | ||
| def get_request_api_version(request) | ||
| matches = request.path.match(API_PATTERN) |
There was a problem hiding this comment.
Use 2 (not 4) spaces for indentation.
| def save(nsc, site_id) | ||
| validate | ||
| uri = "/api/2.1/site_configurations/#{site_id}/alerts" | ||
| id = AJAX.put(nsc, uri, self.to_json, AJAX::CONTENT_TYPE::JSON) |
gschneider-r7
added a commit
that referenced
this pull request
Apr 8, 2015
Merging Staging/v1 into Master Resolves #95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging will bump gem to version 1.0
Resolves #95