Update Nexpose::ScanTemplate methods for device and service discovery #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def enable_icmp_discovery=(enable) | ||
| # Enable/disable ICMP device discovery | ||
| # @param [Boolean] enable Enable or disable ICMP device discovery | ||
| def enable_icmp_device_discovery=(enable) |
There was a problem hiding this comment.
Renaming from 0.9.7? Should another version be published immediately to reduce breakage?
There was a problem hiding this comment.
When this PR is landed, yes, we should release a new version. This PR just makes the method names for enabling/disabling more consistent. In this particular case, it is simply making it more inline with the enable_(tcp|udp)_(device|service)_discovery methods (even though the 'device discovery' part here is technically unnecessary, because there is no "ICMP service discovery")
gschneider-r7
added a commit
that referenced
this pull request
Mar 17, 2015
Update Nexpose::ScanTemplate methods for device and service discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully cleans up all of the rdoc for the methods related to controlling device/service discovery, as well as naming them to more accurately reflect what they do.
The core of methods themselves have not changed and I am not soliciting feedback for anything that was already there, but please ensure that the new naming scheme is consistent, clear and the documentation is now correct. Because there was some rearranging, it may be hard to review this. Try https://github.com/jhart-r7/nexpose-client/blob/feature/template_doc/lib/nexpose/scan_template.rb#L179-272 instead. Nit-pick away!