Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs and .travis.yml #111

Merged
merged 6 commits into from
Feb 11, 2015
Merged

Add specs and .travis.yml #111

merged 6 commits into from
Feb 11, 2015

Conversation

erran-r7
Copy link
Contributor

Fixes #108 /cc @gschneider-r7

  • Create .travis.yml
  • Get someone with admin access to rapid7/nexpose-client configure TravisCI's web hook.
  • Add specs
    • Scaffold the specs directory with a basic spec_helper
    • Define at least one spec
    • Define unit specs
    • Define integration specs
      • which tests the directly against Nexpose API
      • which tests using fixtures that can be anonymized and uploaded to GitHub

@erran-r7
Copy link
Contributor Author

Check out the pull request at erran#1 which demonstrates TravisCI's GitHub integration on my fork of nexpose-client.
screen shot 2015-02-10 at 23 33 06

@erran-r7
Copy link
Contributor Author

@mdaines-r7 Merging this PR into master. We can continue building out the issues but this adds a decent amount of tests and a good boilerplate for adding more.

erran-r7 added a commit that referenced this pull request Feb 11, 2015
Add specs and .travis.yml
@erran-r7 erran-r7 merged commit 22f9f81 into rapid7:master Feb 11, 2015
@erran-r7 erran-r7 deleted the add-specs branch February 11, 2015 19:22
@mdaines-r7
Copy link
Contributor

Cool, I was crunched for time earlier and couldn't merge the PR.

One other thing to add to the list above is to do some coverage metrics. They can be a good guide into what we might be missing (provided there isn't some arbitrary goal set).

@erran-r7
Copy link
Contributor Author

We've used simplecov in other projects under @rapid7 internally. Since this is an open source project maybe we can utilize Code Climate (which the Metasploit team uses): https://codeclimate.com/github/rapid7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automated testing with Travis-CI or similar
3 participants