Ajax clean up #101
Merged
Ajax clean up #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes leading underscore and adds documentation for the method.
Convert to using explicitly private methods for retrieving and setting row preferences. Adds documentation to the preserving_preference method to make it clear why we would use it and to deter external use.
Throws an AuthenticationFailed error when receiving the login page redirect.
Allows calls to override the default 60 second timeout for POST requests which are likely to take more than a minute to complete. Should only be used in rare cases, and not as a workaround for a performance issue.
Private is not supported in module_function methods, so these methods need to be exposed. Also re-organizes the code to keep the row and preference code together in a single section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in the AJAX clean-up work. Mostly involves renaming methods to remove leading underscores. Also adds a timeout parameters to POST calls to support any upload calls which make take a long time to provide a synchronous response.