Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gem Isn't Using Nokogiri #97

Closed
mdaines-r7 opened this issue Dec 29, 2014 · 3 comments
Closed

Gem Isn't Using Nokogiri #97

mdaines-r7 opened this issue Dec 29, 2014 · 3 comments

Comments

@mdaines-r7
Copy link
Contributor

The gem no longer needs to use Nokogiri as a dependency. We have two options:

  1. Sit on it, since we may want to use it for parsing some response objects which are large. If this is the case, we don't have any customers currently complaining about it.
  2. Strip it out, and only re-introduce it if needed. (We are moving toward a JSON API, so this makes more sense to me immediately).
@sgreen-r7
Copy link
Contributor

+1 for Stripping it out.

@nbirnel
Copy link
Contributor

nbirnel commented Dec 30, 2014

As a user, I advocate removing it. If it is not being used, it is not a
dependency, and there is no reason for it to be on my machine. Strip!

On Mon, Dec 29, 2014 at 10:05 AM, Scott Green notifications@github.com
wrote:

+1 for Stripping it out.

—
Reply to this email directly or view it on GitHub
#97 (comment)
.

mdaines-r7 added a commit that referenced this issue Dec 30, 2014
@mdaines-r7
Removes Nokogiri dependency #97 ... not used.
042c2a3
@mdaines-r7
Copy link
Contributor Author

TTFN, Nokogiri!

erran added a commit to erran/nexpose-client that referenced this issue Jan 27, 2015
@erran
Remove unused "require 'nokogiri'"
4266976 
After removing Nokogiri as a dependency (see rapid7#97 and 042c2a3)
requiring Nexpose fails without nokogiri installed.

See rapid7@042c2a3

To reproduce this issue you can use this minimalistic Gemfile:
```ruby
source 'https://rubygems.org'

gem 'nexpose'
```

Using the `bundle exec` command you can exclude any gems not specified
in your Gemfile from your environment:
```
aus-mac-1033 @ ~/g/r/nexpose-polling λ bundle exec ruby -e "require 'nexpose'"
/Users/ecarey/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/nexpose-0.9.3/lib/nexpose.rb:53:in `require': cannot load such file -- nokogiri (LoadError)
        from /Users/ecarey/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/nexpose-0.9.3/lib/nexpose.rb:53:in `<top (required)>'
        from -e:1:in `require'
        from -e:1:in `<main>'
```
@erran erran mentioned this issue Jan 27, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdaines-r7 @nbirnel @sgreen-r7