Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexpose::ReportAdHoc strange behavior with different formats #4

Closed
thesp0nge opened this issue Mar 13, 2012 · 3 comments
Closed

Nexpose::ReportAdHoc strange behavior with different formats #4

thesp0nge opened this issue Mar 13, 2012 · 3 comments

Comments

@thesp0nge
Copy link

Hi there, creating an ad hoc report, if you supply 'text' or 'csv' file format Rex library complains about parse errors.

Using 'html' or 'raw-xml' report is generated.

report = Nexpose::ReportAdHoc.new(nsc, 'report-card', 'text')
report.addFilter('scan', scan[:scan_id])
puts report.generate

@mdaines-r7
Copy link
Contributor

I'm still seeing problems with the Adhoc reports after the refactoring. I didn't actually change the code that handles the report downloading.

What I'm observing is that the non-XML reports download as expected, but XML reports (incl. HTML) with multi-part MIME types don't download everything for the report. If a user doesn't care about the graphs, I think it might still work.

We need to revisit handling of the multi-part MIME types, maybe using a different library. It might also make sense to have a flag on the generate() method to indicate that graphics don't need to be downloaded. (I know that many people just want to parse the data.)

@mdaines-r7
Copy link
Contributor

I have a patch now that will reliably provide the text of HTML and XML reports. It still does not return images, but works around a problem where some Nexpose instances were attempting to parse PNG data as XML and failing to return anything.

@mdaines-r7
Copy link
Contributor

I think we've met the needs of this feature.

gschneider-r7 added a commit that referenced this issue Mar 5, 2015
gschneider-r7 added a commit that referenced this issue Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants