Rex::Encoder::XDR conflicts with the XDR gem #8710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarnett-r7
added a commit
that referenced
this pull request
Jul 12, 2017
The previous use of XDR in these modules allowed for namespace collisions with similar gems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XDR gem that came along for the ride with the Backupexec module conflicts with the SunRPC mixin (which also tries to define XDR), and thus ever module that uses that mixin fails. This explicitly spells out Rex::Encoder::XDR to disambiguate.
List the steps needed to make sure this thing works
msfconsoleuse auxiliary/scanner/nfs/nfsmount