Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc for arp_sweep aux scanner discovery mod #8296 #8414

Merged
merged 3 commits into from
May 19, 2017
Merged

doc for arp_sweep aux scanner discovery mod #8296 #8414

merged 3 commits into from
May 19, 2017

Conversation

renpic
Copy link
Contributor

@renpic renpic commented May 18, 2017

#8296 A doc page for the empty_udp discovery scanner
auxiliary module.

Small fix: the RPORT option is required in the module,
but it is not used in the code; deregister it.

h00die
h00die reviewed May 18, 2017
View reviewed changes
Copy link
Contributor

@h00die h00die left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty solid to me at first glance. For the basic ones like this, I like to include an equivalent way with another tool like nmap. Example: https://github.com/rapid7/metasploit-framework/pull/8372/files
If you have a few moments and can add something similar that would be great.
I'll give this another look in a few hours and see about landing

@renpic
Formatting fix (my bad).
99eaffd 
[*] Start msfconsole
[*] use the module
[*] info -d
[ ] Verify spelling and grammar
@renpic
Copy link
Contributor Author

renpic commented May 18, 2017

Sure, I am gonna add a confirmation step too!

@renpic
Copy link
Contributor Author

renpic commented May 18, 2017

If it's ok, I am gonna work on more aux/scanner/discovery modules in the following days.

@h00die h00die self-assigned this May 18, 2017
@h00die
Copy link
Contributor

h00die commented May 18, 2017

absolutely!
I've got a few of the smb ones queued up i'll put up in the next day or two, but yea that would be great!
They're pretty quick turn around too.

@h00die h00die merged commit 3203937 into rapid7:master May 19, 2017
h00die added a commit that referenced this pull request May 19, 2017
@h00die
Land #8414 docs for aux scanner arp_sweep
90c86db
@h00die
Copy link
Contributor

h00die commented May 19, 2017 •
edited by alrosenthal-r7
Loading

Release Notes

Documentation for the auxiliary/scanner/discovery/arp_sweep module has been added.

@h00die
Copy link
Contributor

h00die commented May 19, 2017

Added one little line to specify which flag was actually doing the scan type: 48b85e9

@renpic renpic deleted the 8296-arp-sweep-doc branch May 19, 2017 18:29
@fairnorthalaska fairnorthalaska mentioned this pull request May 19, 2017
Closed
1 task
@alrosenthal-r7 alrosenthal-r7 added the rn-enhancement release notes enhancement label May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h00die h00die h00die left review comments

Assignees

@h00die h00die

Labels
docs newbie-friendly rn-enhancement release notes enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renpic @h00die @alrosenthal-r7