fix #8121 #8128
Merged
fix #8121 #8128
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, makes sense, thanks @h00die |
busterb
pushed a commit
that referenced
this pull request
Mar 20, 2017
|
I've always kinda' wished that the http mixin would always return a real response object, even if there wasn't a literal response from the host. Just a response code of '000' like akamai does to fill in for a failed session. Would avoid a lot of manual error handling. |
Release NotesThis fix resolves an error that occurs when canon_iradv_pwd_extract receives an unexpected response from the target host. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
resbefore trying to pullcodefrom it.Fixes
auxiliary/scanner/printer/canon_iradv_pwd_extractFixes #8121
@leebaird let me know if this fixes the issue.