Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7687, fix crashing from bad error message argument #7713

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

scriptkittie
Copy link

@scriptkittie scriptkittie commented Dec 15, 2016

What this does

This prevents an exception being thrown if 'msg' from print_error is nil by checking if msg is nil before attempting to work with 'msg'.

Fix #7687

Verification

  • Start with a Windows XP SP3 box or VM for the victim.
  • In attacking machine, start msfconsole
  • DO: use use exploit/multi/handler
  • DO: set payload windows/meterpreter/reverse_tcp
  • DO: set LHOST [IP]
  • DO: set LHOST [PORT]
  • DO: setg SessionLogging true
  • DO: run
  • DO: sysinfo in meterpreter session.
  • You should see no error logs if there is no session information. If there are session logs they will be displayed.
  • The application will not crash if a bad 'msg' is passed to print_error.

@scriptkittie scriptkittie changed the title check for nil msg in print_error Fix #7687, check for nil msg in print_error Dec 15, 2016
@scriptkittie scriptkittie changed the title Fix #7687, check for nil msg in print_error Fix #7687, prevent crashing from bad error messages Dec 15, 2016
@scriptkittie scriptkittie changed the title Fix #7687, prevent crashing from bad error messages Fix #7687, fix crashing from bad error message argument Dec 15, 2016
@thelightcosine thelightcosine self-assigned this Dec 15, 2016
@thelightcosine thelightcosine merged commit 27ba8f0 into rapid7:master Dec 15, 2016
thelightcosine pushed a commit that referenced this pull request Dec 15, 2016
lands a fix for loggers not handling a nil message
Fix for #7687
@tdoan-r7
Copy link
Contributor

Release Notes

This fix prevents an exception being thrown if 'msg' from print_error is nil by checking if msg is nil before attempting to work with 'msg'.

@tdoan-r7 tdoan-r7 added the rn-fix release notes fix label Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants