Add support for ZIP file generation in zip_slip exploit #14075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggkitsas
changed the title
Comment on lines
51
to
52
| OptString.new('FILENAME', [true, 'The tar file (tar)', 'msf.tar']), | ||
| OptString.new('FNAME', [true, 'The name of the archive file (without extension)', 'msf']), |
There was a problem hiding this comment.
This parameter should still be named FILENAME for a couple of reasons.
- With the new
FTYPEdefaulting totarwe can keep this at the same value asmsf.tarand maintain backwards compatibility FTYPEis presumably short for "file type" not "file extension". If the user wants to name their ZIP filesomething.tarwe should allow them to. This might seem odd for zip vs tar, but consider scenarios where the user wants to impersonate a file type based on ZIPs such as CBZ or JAR.
bwatters-r7
added a commit
that referenced
this pull request
Sep 2, 2020
Merge branch 'land-14075' into upstream-master
Release NotesUpdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for generating ZIP files for the zip_slip exploit.
Verification
msfconsoleuse exploits/multi/fileformat/zip_slipset FTYPE zipexploitmsf.zipshould be createdzipinfo -1 msf.zipshould present../payload.bin