Adding batch_update_findings functionality to AWS SecurityHub integration - #3948
Open
danielperez660 wants to merge 22 commits into
Open
Adding batch_update_findings functionality to AWS SecurityHub integration#3948danielperez660 wants to merge 22 commits into
danielperez660 wants to merge 22 commits into
Conversation
added 10 commits
June 11, 2026 14:50
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
danielperez660
changed the title
Author
|
Hey @ewilson-r7 are you, or anyone in your team free to look into this? |
ewilson-r7
requested changes
Jun 15, 2026
Collaborator
There was a problem hiding this comment.
Hey @danielperez660, thanks for putting this together — the feature fills a real gap and the approach is solid. I've left inline comments on the specific areas that need attention before we can merge.
Summary
| Category | Count |
|---|---|
| 🔴 Critical (must fix) | 3 |
| 🟡 Moderate (should fix) | 5 |
| 🟢 Minor (nice to fix) | 3 |
Biggest concerns: the falsy-value filter bug, missing error handling, empty unit tests, and several spec YAML issues.
…ch_update_findings/action.py applying better naming standards for dictionary comprehension Co-authored-by: Eric Wilson <74607561+ewilson-r7@users.noreply.github.com>
danielperez660
force-pushed
the
SecurityHubArchiveFindings
branch
from
June 16, 2026 08:35
ef48fc4 to
440f1ac
Compare
Updating title Co-authored-by: Eric Wilson <74607561+ewilson-r7@users.noreply.github.com>
danielperez660
changed the title
added 7 commits
June 16, 2026 14:58
danielperez660
changed the title
Author
|
@ewilson-r7 I think that's all of the issues addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 Type of Change
🧠 Background & Motivation
We can only read from Security Hub whereas to fully integrate with it, we should also be able to write to it. To do this, I have integrated the boto3 functionality of
batch_update_findings- which will allow users to write and close findings directly from Rapid7 rather than having to do this manually or rolling out their own keystore/auth in python connections, which is the current requirement.✨ What Changed
Added a new action to the aws_securityhub plugin to allow updating of securityhub findings.
🧪 Testing
Testing has been done manually to confirm that the findings IDs which are passed to the Rapid7 connection are updated where needed
