Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add throwable suppresion and field access tests #876

Closed
wants to merge 2 commits into from

Conversation

felixbarny
Copy link
Contributor

both tests are currently failing

testThrowingAssigningEnterPostProcessorInline shows that exceptions in advices override the arguments with null

testFieldAssigningEnterPostProcessorDelegate yields a verify error

java.lang.VerifyError: Operand stack underflow
Exception Details:
  Location:
    net/bytebuddy/asm/AdviceTest$PostProcessorFieldAccessDelegateTest.foo(Ljava/lang/String;)Ljava/lang/String; @5: putfield
  Reason:
    Attempt to pop empty stack.
  Current Frame:
    bci: @5
    flags: { }
    locals: { 'net/bytebuddy/asm/AdviceTest$PostProcessorFieldAccessDelegateTest', 'java/lang/String', 'java/lang/String' }
    stack: { 'java/lang/String' }
  Bytecode:
    0000000: b800 274d 2cb5 0003 2ab4 0003 b0       
  Stackmap Table:
    same_frame(@8)

@raphw raphw self-assigned this Jun 4, 2020
@raphw raphw added the question label Jun 4, 2020
@raphw raphw added this to the 1.10.10 milestone Jun 4, 2020
@raphw raphw closed this Jun 4, 2020
@felixbarny felixbarny deleted the post-processor branch June 5, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants