[scratch] ISBN corpus validation harness (do not merge) - #4
Closed
raphi011 wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Closing — scratch validation harness was opened by mistake; not intended as a PR. Branch kept locally for re-runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A throwaway local validation harness for
metadata.isbns(from PR #2). It runs the full public pipeline (AssetRetriever.retrieve→PublicationOpener.open→publication.metadata.isbns) over a real corpus of EPUBs in~/ebooksand reports correctness flags. It reads an absolute host path and skips when the corpus is absent, so it's a no-op in CI. Based onfeat/epub-isbn-metadata(the harness callsmetadata.isbns, which isn't ondevelopyet).What it checks
isbn(case-insensitive) butmetadata.isbnsis empty → a marker we don't detect.[0-9X]).It's a report, not a pass/fail gate (the flags need human review); the only assertion is that ≥1 book opened.
Run
Results (329-book corpus, 10.6s)
opf:scheme, value prefix, ONIXidentifier-typerefine) — no parser bugs.p…-prefixed values (Flag B), all from nonstandard markers (ISBN only in theidattribute /dc:source/ unmarked; Penguinp-prefixed values returned verbatim). Decision: leave as-is — these are a deliberate non-goal for the minimal parser.