Fixed NPE Caused By HTTP Methods that would resemble Accessors#83
Open
wwhitlow wants to merge 1 commit intoraphaeljolivet:masterfrom
Open
Fixed NPE Caused By HTTP Methods that would resemble Accessors#83wwhitlow wants to merge 1 commit intoraphaeljolivet:masterfrom
wwhitlow wants to merge 1 commit intoraphaeljolivet:masterfrom
Conversation
wwhitlow
force-pushed
the
master
branch
5 times, most recently
from
225024e to
d77f0bf
Compare
similar structure to accessor methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negated a potential NPE that was caused be HTTP methods that had a similar structure to accessor methods.
Modified ExampleService in DescriptorGeneratorTest to as an example to the type of edge case that currently causes this issue.
Fixes problems addressed in issue #40 in a manner matching the discussion that was had there.