Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyperlink enhancements: Editing URL, removing hyperlink (solves #35) #43

Merged
merged 4 commits into from
Feb 13, 2014
Merged

Hyperlink enhancements: Editing URL, removing hyperlink (solves #35) #43

merged 4 commits into from
Feb 13, 2014

Conversation

slahn
Copy link
Contributor

@slahn slahn commented Feb 12, 2014

I've made two improvements to hyperlink editing:

  • When selecing a link and pressing the anchor button on the bubble, the existing address is pre-filled
  • Added a way to remove a hyperlink. Currently this triggers when editing a link, clearing the address, and pressing enter.

This should resolve #35

I also add utils.selection.getContainer(selection), that should work cross-browser, and gets the element containing the selection.

@slahn slahn mentioned this pull request Feb 12, 2014
Closed
@raphaelcruzeiro
Copy link
Owner

This should also resolve #29

raphaelcruzeiro added a commit that referenced this pull request Feb 13, 2014
@raphaelcruzeiro
Merge pull request #43 from slahn/master
3c20847 
Hyperlink enhancements: Editing URL, removing hyperlink (solves #35)
This should also resolve #29

Awesome! Thank you!
@raphaelcruzeiro raphaelcruzeiro merged commit 3c20847 into raphaelcruzeiro:master Feb 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It's still not possible to remove a hyperlink
2 participants
@slahn @raphaelcruzeiro