Exception thrown if file is not readable #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulkur
changed the title
|
Thank you for this contribution! I'll try to release it soon! |
bethuxs
pushed a commit
to bethuxs/laravel-log-viewer
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case log file is not readable (generated by some other process, cron etc) exception is thrown.
This PR checks for that and returns message about it as log content.
Thoughts on what would be the best way to make it clear it is an error message from package and not actual log file content?
It would also be possible to mark files as unreadable in file list but that requires checking all files at every load and might not be advisable. Thoughts?