Skip to content

Minor fixes #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Minor fixes #19

wants to merge 9 commits into from

Conversation

majdisorder
Copy link

  • Updated .gitignore to latest from https://github.com/github/gitignore/blob/master/VisualStudio.gitignore
  • Fixed inconsistent access modifiers for ExtendedClientConfiguration properties. All properties now have private setters, as I feel the configuratiuon object should be immutable.
  • Changed MessageSizeThreshold type from int to long. This makes more sense, as IsLarge compares this with LongCount of the message bytes.
  • Fixed ExtendedClientConfiguration ctor to copy the S3KeyProvider from 'other'.
  • Fixed a typo in an exception message.
  • Fixed typo in S3KeyProvider property and Interface name. I realize this could cause some issues concerning backwards compatibility, so maybe this deserves a major version bump.

@majdisorder
Copy link
Author

just realized i forgot to change the type for the messageSizeThreshold parameter in WithMessageSizeThreshold

<PackageProjectUrl>https://github.com/raol/amazon-sqs-net-extended-client-lib</PackageProjectUrl>
<PackageLicenseUrl>https://github.com/raol/amazon-sqs-net-extended-client-lib/blob/master/LICENSE</PackageLicenseUrl>
<RepositoryUrl>https://github.com/raol/amazon-sqs-net-extended-client-lib</RepositoryUrl>
<PackageProjectUrl>https://github.com/dimi3tron/amazon-sqs-net-extended-client-lib</PackageProjectUrl>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. I don't get why such a change was introduced.

@@ -1,16 +1,16 @@
namespace Amazon.SQS.ExtendedClient
{
using Model;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rearrange using as the were.
System* ones should come first.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's resharper that orders the imports alphabetically on save. I'll see if I can disable this.

@raol
Copy link
Owner

raol commented Dec 9, 2019

@majdisorder
Copy link
Author

And the build, it's broken
https://ci.appveyor.com/project/raol/amazon-sqs-net-extended-client-lib/builds/29319522
m
hmm.. yes, I signed assembly so I could use it in my own project. Should not have committed that i guess. I'll revert and create a separate branch for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants