-
Notifications
You must be signed in to change notification settings - Fork 33
Minor fixes #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Minor fixes #19
Conversation
just realized i forgot to change the type for the |
<PackageProjectUrl>https://github.com/raol/amazon-sqs-net-extended-client-lib</PackageProjectUrl> | ||
<PackageLicenseUrl>https://github.com/raol/amazon-sqs-net-extended-client-lib/blob/master/LICENSE</PackageLicenseUrl> | ||
<RepositoryUrl>https://github.com/raol/amazon-sqs-net-extended-client-lib</RepositoryUrl> | ||
<PackageProjectUrl>https://github.com/dimi3tron/amazon-sqs-net-extended-client-lib</PackageProjectUrl> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. I don't get why such a change was introduced.
@@ -1,16 +1,16 @@ | |||
namespace Amazon.SQS.ExtendedClient | |||
{ | |||
using Model; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rearrange using as the were.
System*
ones should come first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's resharper that orders the imports alphabetically on save. I'll see if I can disable this.
And the build, it's broken |
|
ExtendedClientConfiguration
properties. All properties now have private setters, as I feel the configuratiuon object should be immutable.MessageSizeThreshold
type fromint
tolong
. This makes more sense, asIsLarge
compares this withLongCount
of the message bytes.ExtendedClientConfiguration
ctor to copy theS3KeyProvider
from 'other'.S3KeyProvider
property and Interface name. I realize this could cause some issues concerning backwards compatibility, so maybe this deserves a major version bump.