Added ability to retrieve message details in case of failed to get data from S3 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raol
reviewed
Oct 21, 2019
| message.ReceiptHandle = EmbedS3PointerInReceiptHandle(message.ReceiptHandle, messageS3Pointer.S3BucketName, messageS3Pointer.S3Key); | ||
| message.MessageAttributes.Remove(SQSExtendedClientConstants.RESERVED_ATTRIBUTE_NAME); | ||
| } | ||
| catch (AmazonClientException amazonClientException) |
There was a problem hiding this comment.
Shouldn't the same try/catch be used when the message is removed from the queue?
I mean, if one tries to delete non-existing s3 payload, will exception be raised?
If so, then it would be nice to have the same exception handling logics there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found your library very helpful in case of bigger payloads. When doing tests I found some scenarios that cannot be covered using existing implementation because the lack of information about messages received from the Amazon service (sqs).
In my scenario I would like to be able to get the receipt handle and delete the message when I get AmazonS3Exception saying the payload is gone (somehow removed) while receiving the message.
Hope you will find my PR usefull.