Add comparison with node:crypto and clarify parameter usage in README.md - #491
Merged
Conversation
Owner
|
This is really good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for the awesome work with this library and getting a native implementation of argon2 into node.
I began work on replacing this library with the native implementation in a project, but i quickly noticed that they are not comparable at all.
After reading through your The future of node-argon2 issue i quickly came to the conclusion that this library is still the way to go for password hashing.
I think it would be good to include some of your comments from that issue in the readme, and a comparison table with the native implementation.
Password hashing is hard, and the native APIs are not user friendly if you don't know what you are doing. Nudging people to use this library instead seems like the way to go.