Feat/rf 1863 migrate clover to hub #957

nikaaru · 2024-11-25T10:44:12Z

Summary

Clover has been migrated to hub and also in addition to Solana namespace, EVM namespace has been added too.
The Solana namespace has a problem with transaction signing, which we also have on production, and we will fix it in a separate PR.

I also added changeChainSubscriber to its EVM namespace.

I took this branch from the feat/rf-1970-add-chain-change-subscribe-to-evm-namespace branch in this PR.

Checklist:

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

- widget-embedded@0.30.1-next.4 Affected packages: widget-embedded@0.30.1-next.4 [skip ci]

- widget-embedded@0.30.1-next.5 Affected packages: widget-embedded@0.30.1-next.5 [skip ci]

…ALLET

- widget-embedded@0.30.1-next.6 Affected packages: widget-embedded@0.30.1-next.6 [skip ci]

…blockchain in the widget config

- widget-embedded@0.30.1-next.7 Affected packages: widget-embedded@0.30.1-next.7 [skip ci]

- provider-ledger@0.5.2-next.1 - provider-trezor@0.2.2-next.1 - provider-all@0.35.2-next.1 - wallets-adapter@0.30.1-next.3 - widget-embedded@0.30.1-next.8 Affected packages: provider-ledger@0.5.2-next.1,provider-trezor@0.2.2-next.1,provider-all@0.35.2-next.1,wallets-adapter@0.30.1-next.3,widget-embedded@0.30.1-next.8 [skip ci]

… out of src

- signer-starknet@0.28.1-next.1 - wallets-shared@0.35.2-next.0 - signer-evm@0.28.1-next.1 - signer-tron@0.27.1-next.1 - signer-solana@0.30.1-next.1 - signer-cosmos@0.27.1-next.1 - logging-types@0.5.1-next.1 - signer-ton@0.13.1-next.1 - queue-manager-core@0.26.1-next.0 - signer-terra@0.27.1-next.1 - provider-argentx@0.36.2-next.1 - provider-bitget@0.32.2-next.1 - provider-braavos@0.29.2-next.1 - provider-brave@0.36.2-next.1 - provider-clover@0.36.2-next.1 - provider-coin98@0.36.2-next.1 - provider-coinbase@0.35.2-next.1 - provider-cosmostation@0.35.2-next.1 - provider-default@0.32.2-next.1 - provider-enkrypt@0.35.2-next.1 - provider-exodus@0.35.2-next.1 - provider-frontier@0.35.2-next.1 - provider-halo@0.35.2-next.1 - provider-keplr@0.35.2-next.1 - provider-leap-cosmos@0.35.2-next.1 - provider-ledger@0.5.2-next.2 - provider-math-wallet@0.35.2-next.1 - provider-metamask@0.35.2-next.1 - provider-okx@0.35.2-next.1 - provider-phantom@0.35.2-next.1 - provider-rabby@0.2.2-next.1 - provider-safe@0.28.2-next.1 - provider-safepal@0.35.2-next.1 - provider-taho@0.35.2-next.1 - provider-tokenpocket@0.35.2-next.1 - provider-tomo@0.2.2-next.1 - provider-trezor@0.2.2-next.2 - provider-tron-link@0.35.2-next.1 - provider-trustwallet@0.35.2-next.1 - logging-core@0.5.1-next.1 - provider-xdefi@0.35.2-next.1 - wallets-core@0.36.2-next.1 - ui@0.36.1-next.3 - provider-mytonwallet@0.20.2-next.1 - queue-manager-react@0.26.1-next.0 - provider-station@0.34.2-next.1 - logging-sentry@0.5.1-next.1 - logging-console@0.5.1-next.1 - logging-subscriber@0.5.1-next.1 - provider-solflare-snap@0.6.2-next.1 - provider-walletconnect-2@0.28.2-next.1 - wallets-react@0.21.2-next.1 - queue-manager-rango-preset@0.35.2-next.1 - provider-all@0.35.2-next.2 - wallets-adapter@0.30.1-next.4 - widget-embedded@0.30.1-next.9 Affected packages: signer-starknet@0.28.1-next.1,wallets-shared@0.35.2-next.0,signer-evm@0.28.1-next.1,signer-tron@0.27.1-next.1,signer-solana@0.30.1-next.1,signer-cosmos@0.27.1-next.1,logging-types@0.5.1-next.1,signer-ton@0.13.1-next.1,queue-manager-core@0.26.1-next.0,signer-terra@0.27.1-next.1,provider-argentx@0.36.2-next.1,provider-bitget@0.32.2-next.1,provider-braavos@0.29.2-next.1,provider-brave@0.36.2-next.1,provider-clover@0.36.2-next.1,provider-coin98@0.36.2-next.1,provider-coinbase@0.35.2-next.1,provider-cosmostation@0.35.2-next.1,provider-default@0.32.2-next.1,provider-enkrypt@0.35.2-next.1,provider-exodus@0.35.2-next.1,provider-frontier@0.35.2-next.1,provider-halo@0.35.2-next.1,provider-keplr@0.35.2-next.1,provider-leap-cosmos@0.35.2-next.1,provider-ledger@0.5.2-next.2,provider-math-wallet@0.35.2-next.1,provider-metamask@0.35.2-next.1,provider-okx@0.35.2-next.1,provider-phantom@0.35.2-next.1,provider-rabby@0.2.2-next.1,provider-safe@0.28.2-next.1,provider-safepal@0.35.2-next.1,provider-taho@0.35.2-next.1,provider-tokenpocket@0.35.2-next.1,provider-tomo@0.2.2-next.1,provider-trezor@0.2.2-next.2,provider-tron-link@0.35.2-next.1,provider-trustwallet@0.35.2-next.1,logging-core@0.5.1-next.1,provider-xdefi@0.35.2-next.1,wallets-core@0.36.2-next.1,ui@0.36.1-next.3,provider-mytonwallet@0.20.2-next.1,queue-manager-react@0.26.1-next.0,provider-station@0.34.2-next.1,logging-sentry@0.5.1-next.1,logging-console@0.5.1-next.1,logging-subscriber@0.5.1-next.1,provider-solflare-snap@0.6.2-next.1,provider-walletconnect-2@0.28.2-next.1,wallets-react@0.21.2-next.1,queue-manager-rango-preset@0.35.2-next.1,provider-all@0.35.2-next.2,wallets-adapter@0.30.1-next.4,widget-embedded@0.30.1-next.9 [skip ci]

preparing legacy wallet management to be deprecated

- wallets-shared@0.35.2-next.1 - provider-argentx@0.36.2-next.2 - provider-bitget@0.32.2-next.2 - provider-braavos@0.29.2-next.2 - provider-brave@0.36.2-next.2 - provider-clover@0.36.2-next.2 - provider-coin98@0.36.2-next.2 - provider-coinbase@0.35.2-next.2 - provider-cosmostation@0.35.2-next.2 - provider-default@0.32.2-next.2 - provider-enkrypt@0.35.2-next.2 - provider-exodus@0.35.2-next.2 - provider-frontier@0.35.2-next.2 - provider-halo@0.35.2-next.2 - provider-keplr@0.35.2-next.2 - provider-leap-cosmos@0.35.2-next.2 - provider-ledger@0.5.2-next.3 - provider-math-wallet@0.35.2-next.2 - provider-metamask@0.35.2-next.2 - provider-okx@0.35.2-next.2 - provider-phantom@0.35.2-next.2 - provider-rabby@0.2.2-next.2 - provider-safe@0.28.2-next.2 - provider-safepal@0.35.2-next.2 - provider-taho@0.35.2-next.2 - provider-tokenpocket@0.35.2-next.2 - provider-tomo@0.2.2-next.2 - provider-trezor@0.2.2-next.3 - provider-tron-link@0.35.2-next.2 - provider-trustwallet@0.35.2-next.2 - provider-walletconnect-2@0.28.2-next.2 - provider-xdefi@0.35.2-next.2 - wallets-core@0.36.2-next.2 - ui@0.36.1-next.4 - provider-mytonwallet@0.20.2-next.2 - provider-station@0.34.2-next.2 - provider-solflare-snap@0.6.2-next.2 - wallets-react@0.21.2-next.2 - queue-manager-rango-preset@0.35.2-next.2 - provider-all@0.35.2-next.3 - wallets-adapter@0.30.1-next.5 - widget-embedded@0.30.1-next.10 Affected packages: wallets-shared@0.35.2-next.1,provider-argentx@0.36.2-next.2,provider-bitget@0.32.2-next.2,provider-braavos@0.29.2-next.2,provider-brave@0.36.2-next.2,provider-clover@0.36.2-next.2,provider-coin98@0.36.2-next.2,provider-coinbase@0.35.2-next.2,provider-cosmostation@0.35.2-next.2,provider-default@0.32.2-next.2,provider-enkrypt@0.35.2-next.2,provider-exodus@0.35.2-next.2,provider-frontier@0.35.2-next.2,provider-halo@0.35.2-next.2,provider-keplr@0.35.2-next.2,provider-leap-cosmos@0.35.2-next.2,provider-ledger@0.5.2-next.3,provider-math-wallet@0.35.2-next.2,provider-metamask@0.35.2-next.2,provider-okx@0.35.2-next.2,provider-phantom@0.35.2-next.2,provider-rabby@0.2.2-next.2,provider-safe@0.28.2-next.2,provider-safepal@0.35.2-next.2,provider-taho@0.35.2-next.2,provider-tokenpocket@0.35.2-next.2,provider-tomo@0.2.2-next.2,provider-trezor@0.2.2-next.3,provider-tron-link@0.35.2-next.2,provider-trustwallet@0.35.2-next.2,provider-walletconnect-2@0.28.2-next.2,provider-xdefi@0.35.2-next.2,wallets-core@0.36.2-next.2,ui@0.36.1-next.4,provider-mytonwallet@0.20.2-next.2,provider-station@0.34.2-next.2,provider-solflare-snap@0.6.2-next.2,wallets-react@0.21.2-next.2,queue-manager-rango-preset@0.35.2-next.2,provider-all@0.35.2-next.3,wallets-adapter@0.30.1-next.5,widget-embedded@0.30.1-next.10 [skip ci]

this is part of preparation for our upcomin wallet management

- wallets-react@0.21.2-next.3 - provider-all@0.35.2-next.4 - wallets-adapter@0.30.1-next.6 - widget-embedded@0.30.1-next.11 Affected packages: wallets-react@0.21.2-next.3,provider-all@0.35.2-next.4,wallets-adapter@0.30.1-next.6,widget-embedded@0.30.1-next.11 [skip ci]

- ui@0.36.1-next.5 - wallets-adapter@0.30.1-next.7 - widget-embedded@0.30.1-next.12 Affected packages: ui@0.36.1-next.5,wallets-adapter@0.30.1-next.7,widget-embedded@0.30.1-next.12 [skip ci]

- widget-embedded@0.30.1-next.13 Affected packages: widget-embedded@0.30.1-next.13 [skip ci]

…idget

- widget-embedded@0.30.1-next.14 Affected packages: widget-embedded@0.30.1-next.14 [skip ci]

- ui@0.36.1-next.6 - wallets-adapter@0.30.1-next.8 - widget-embedded@0.30.1-next.15 Affected packages: ui@0.36.1-next.6,wallets-adapter@0.30.1-next.8,widget-embedded@0.30.1-next.15 [skip ci]

- ui@0.36.1-next.7 - queue-manager-core@0.26.1-next.1 - wallets-adapter@0.30.1-next.9 - queue-manager-react@0.26.1-next.1 - queue-manager-rango-preset@0.35.2-next.3 - widget-embedded@0.30.1-next.16 Affected packages: ui@0.36.1-next.7,queue-manager-core@0.26.1-next.1,wallets-adapter@0.30.1-next.9,queue-manager-react@0.26.1-next.1,queue-manager-rango-preset@0.35.2-next.3,widget-embedded@0.30.1-next.16 [skip ci]

chore: post release syncing

…fault.

- wallets-core@0.40.1-next.0 - wallets-shared@0.40.1-next.0 - provider-argentx@0.41.1-next.0 - provider-bitget@0.37.1-next.0 - provider-braavos@0.34.1-next.0 - provider-brave@0.41.1-next.0 - provider-clover@0.41.1-next.0 - provider-coin98@0.41.1-next.0 - provider-coinbase@0.40.1-next.0 - provider-cosmostation@0.40.1-next.0 - provider-default@0.37.1-next.0 - provider-enkrypt@0.40.1-next.0 - provider-exodus@0.40.1-next.0 - provider-frontier@0.40.1-next.0 - provider-halo@0.40.1-next.0 - provider-keplr@0.40.1-next.0 - provider-leap-cosmos@0.40.1-next.0 - provider-ledger@0.10.1-next.0 - provider-math-wallet@0.40.1-next.0 - provider-metamask@0.40.1-next.0 - provider-mytonwallet@0.25.1-next.0 - provider-okx@0.40.1-next.0 - provider-phantom@0.40.1-next.0 - provider-rabby@0.7.1-next.0 - provider-safe@0.33.1-next.0 - provider-safepal@0.40.1-next.0 - provider-solflare@0.6.1-next.0 - provider-taho@0.40.1-next.0 - provider-tokenpocket@0.40.1-next.0 - provider-tomo@0.7.1-next.0 - provider-tonconnect@0.2.1-next.0 - provider-trezor@0.7.1-next.0 - provider-tron-link@0.40.1-next.0 - provider-trustwallet@0.40.1-next.0 - provider-walletconnect-2@0.33.1-next.0 - provider-xdefi@0.40.1-next.0 - wallets-react@0.26.1-next.0 - ui@0.42.1-next.0 - queue-manager-rango-preset@0.40.1-next.0 - provider-station@0.39.1-next.0 - provider-solflare-snap@0.11.1-next.0 - charts@0.4.1-next.0 - provider-all@0.40.1-next.0 - wallets-adapter@0.36.1-next.0 - widget-embedded@0.36.1-next.0 Affected packages: wallets-core@0.40.1-next.0,wallets-shared@0.40.1-next.0,provider-argentx@0.41.1-next.0,provider-bitget@0.37.1-next.0,provider-braavos@0.34.1-next.0,provider-brave@0.41.1-next.0,provider-clover@0.41.1-next.0,provider-coin98@0.41.1-next.0,provider-coinbase@0.40.1-next.0,provider-cosmostation@0.40.1-next.0,provider-default@0.37.1-next.0,provider-enkrypt@0.40.1-next.0,provider-exodus@0.40.1-next.0,provider-frontier@0.40.1-next.0,provider-halo@0.40.1-next.0,provider-keplr@0.40.1-next.0,provider-leap-cosmos@0.40.1-next.0,provider-ledger@0.10.1-next.0,provider-math-wallet@0.40.1-next.0,provider-metamask@0.40.1-next.0,provider-mytonwallet@0.25.1-next.0,provider-okx@0.40.1-next.0,provider-phantom@0.40.1-next.0,provider-rabby@0.7.1-next.0,provider-safe@0.33.1-next.0,provider-safepal@0.40.1-next.0,provider-solflare@0.6.1-next.0,provider-taho@0.40.1-next.0,provider-tokenpocket@0.40.1-next.0,provider-tomo@0.7.1-next.0,provider-tonconnect@0.2.1-next.0,provider-trezor@0.7.1-next.0,provider-tron-link@0.40.1-next.0,provider-trustwallet@0.40.1-next.0,provider-walletconnect-2@0.33.1-next.0,provider-xdefi@0.40.1-next.0,wallets-react@0.26.1-next.0,ui@0.42.1-next.0,queue-manager-rango-preset@0.40.1-next.0,provider-station@0.39.1-next.0,provider-solflare-snap@0.11.1-next.0,charts@0.4.1-next.0,provider-all@0.40.1-next.0,wallets-adapter@0.36.1-next.0,widget-embedded@0.36.1-next.0 [skip ci]

wallets/provider-clover/src/constants.ts

wallets/provider-clover/src/namespaces/solana.ts

wallets/core/src/hub/mod.ts

wallets/provider-clover/src/actions/solana.ts

github-actions bot and others added 30 commits July 21, 2024 06:38

chore(release): publish

fdf7e13

- widget-embedded@0.30.1-next.4 Affected packages: widget-embedded@0.30.1-next.4 [skip ci]

fix: fix sort logic of notifications

ffcf4c2

chore(release): publish

ffcc421

- widget-embedded@0.30.1-next.5 Affected packages: widget-embedded@0.30.1-next.5 [skip ci]

feat: add preventable event and a new ui event called CLICK_CONNECT_W…

e4363bb

…ALLET

chore(release): publish

86eb974

- widget-embedded@0.30.1-next.6 Affected packages: widget-embedded@0.30.1-next.6 [skip ci]

feat: add the option to define a default custom destination for each …

7982ab6

…blockchain in the widget config

chore(release): publish

a2c7562

- widget-embedded@0.30.1-next.7 Affected packages: widget-embedded@0.30.1-next.7 [skip ci]

feat: add derivation path modal for trezor wallet

364422f

chore: separating tsconfigs for being able to keep intergration tests…

810d638

… out of src

feat: accept multiple entrypoints for build script

2ef116f

chore: move wallet core files to legacy

bef621b

preparing legacy wallet management to be deprecated

chore: fix hoisting @types/web and conflicting with @types/dom

bd4dc78

chore: migrate wallets core and shared to nodenext module

3ed2d28

chore: move wallets react code to a subfolder called legacy

535fb74

this is part of preparation for our upcomin wallet management

chore: enable nodenext module system for wallets/react

fd7d863

feat: hide balance and max button when no wallet connected

80b2754

chore(release): publish

40229dc

- ui@0.36.1-next.5 - wallets-adapter@0.30.1-next.7 - widget-embedded@0.30.1-next.12 Affected packages: ui@0.36.1-next.5,wallets-adapter@0.30.1-next.7,widget-embedded@0.30.1-next.12 [skip ci]

fix: fix missing usd value in estimated output

a46d19a

chore(release): publish

8aaee05

- widget-embedded@0.30.1-next.13 Affected packages: widget-embedded@0.30.1-next.13 [skip ci]

feat: add functionality to update the quote inputs from outside the w…

d9722fb

…idget

chore(release): publish

f1df9ef

- widget-embedded@0.30.1-next.14 Affected packages: widget-embedded@0.30.1-next.14 [skip ci]

fix: fix bug in swap input handling empty value

3c9b082

chore(release): publish

e67b95a

- ui@0.36.1-next.6 - wallets-adapter@0.30.1-next.8 - widget-embedded@0.30.1-next.15 Affected packages: ui@0.36.1-next.6,wallets-adapter@0.30.1-next.8,widget-embedded@0.30.1-next.15 [skip ci]

chore: exclude tsconfig files from analyze bundle required artifacts

722eb5c

feat: add filter and clear to widget history

d43b603

yeager-eren and others added 3 commits November 27, 2024 19:58

Merge pull request #961 from rango-exchange/main

a7274d0

chore: post release syncing

feat: add an adapter for Hub for wallets-react and enabling Hub by de…

a14bdf9

…fault.

nikaaru force-pushed the feat/rf-1970-add-chain-change-subscribe-to-evm-namespace branch from d714cf3 to 4e0fa67 Compare December 1, 2024 09:17

nikaaru requested review from mikasackermn and samobasquiat as code owners December 1, 2024 09:17

nikaaru added 2 commits December 1, 2024 13:08

feat: add chain change subscribe to evm namespace

0a7e7ee

fix: fix frozen accounts array

5438438

Base automatically changed from feat/rf-1970-add-chain-change-subscribe-to-evm-namespace to next December 1, 2024 10:08

feat: migrate clover from legacy to hub

c1da199

nikaaru force-pushed the feat/rf-1863-migrate-clover-to-hub branch from 48944a5 to c1da199 Compare December 1, 2024 10:15

nikaaru deployed to playground-preview December 1, 2024 10:25 — with GitHub Actions View deployment

nikaaru deployed to storybook-preview December 1, 2024 10:25 — with GitHub Actions View deployment

nikaaru deployed to app-preview December 1, 2024 10:25 — with GitHub Actions View deployment

yeager-eren requested changes Dec 2, 2024

View reviewed changes

wallets/provider-clover/src/constants.ts Outdated Show resolved Hide resolved

wallets/provider-clover/src/namespaces/solana.ts Show resolved Hide resolved

chore: add custom action for changeAccountSubscriber

6bb9abc

nikaaru deployed to playground-preview December 4, 2024 15:09 — with GitHub Actions View deployment

nikaaru deployed to storybook-preview December 4, 2024 15:09 — with GitHub Actions View deployment

nikaaru deployed to app-preview December 4, 2024 15:09 — with GitHub Actions View deployment

yeager-eren approved these changes Dec 8, 2024

View reviewed changes

wallets/core/src/hub/mod.ts Outdated Show resolved Hide resolved

wallets/provider-clover/src/actions/solana.ts Show resolved Hide resolved

nikaaru deployed to playground-preview December 9, 2024 08:07 — with GitHub Actions View deployment

nikaaru deployed to storybook-preview December 9, 2024 08:07 — with GitHub Actions View deployment

nikaaru deployed to app-preview December 9, 2024 08:07 — with GitHub Actions View deployment

chore: remove hub from exporting

a5703c2

nikaaru force-pushed the feat/rf-1863-migrate-clover-to-hub branch from 2c2e854 to a5703c2 Compare December 9, 2024 08:15

nikaaru deployed to playground-preview December 9, 2024 08:26 — with GitHub Actions View deployment

nikaaru deployed to app-preview December 9, 2024 08:26 — with GitHub Actions View deployment

nikaaru deployed to storybook-preview December 9, 2024 08:26 — with GitHub Actions View deployment

yeager-eren force-pushed the next branch from d05c245 to 3f2dfb9 Compare June 11, 2025 11:23

yeager-eren requested a review from Ikari-Shinji-re as a code owner June 11, 2025 11:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat/rf 1863 migrate clover to hub #957

Feat/rf 1863 migrate clover to hub #957

Uh oh!

nikaaru commented Nov 25, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Feat/rf 1863 migrate clover to hub #957

Are you sure you want to change the base?

Feat/rf 1863 migrate clover to hub #957

Uh oh!

Conversation

nikaaru commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nikaaru commented Nov 25, 2024 •

edited

Loading