Displaying clickable text for showing messages #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randrescastaneda
requested changes
Sep 25, 2024
There was a problem hiding this comment.
hi @RossanaTat ,
Thank you so much. The changes look really good. I made a few suggestions. Please review and push again.
Thanks.
R/joyn-merge.R
Outdated
Comment on lines
546
to
553
| notes_count <- sum( | ||
| .joynenv$joyn_msgs$type %in% c("info", "note") | ||
| ) | ||
|
|
||
| warn_count <- sum( | ||
| .joynenv$joyn_msgs$type == "warn" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Hi @RossanaTat ,
thank you so much.
What happens when .joynenv$joyn_msgs$typeis NULL or has NA? I suggest you retrieve joyn_msgs with rlang::env_get() and use either sum( na.rm = TRUE) or fsum() from collapse.
Thanks.
There was a problem hiding this comment.
Hi @randrescastaneda, thank you for reviewing. I have pushed some changes following your suggestions, and also to show the user the clickable messages only if there are any. Let me know if it looks okay now. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.