Fix voxpupuliGH-205 raise exception on bad source paramters

randradas · Oct 30, 2016 · 2e3311d · 2e3311d
1 parent 96b9c7f
commit 2e3311d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/examples/bad_source.pp b/examples/bad_source.pp
@@ -0,0 +1,5 @@
+archive { '/tmp/jta-1.1.jar':
+  ensure => present,
+  source => $bad_variable,
+}
+
diff --git a/lib/puppet/provider/archive/ruby.rb b/lib/puppet/provider/archive/ruby.rb
@@ -129,6 +129,8 @@ def transfer_download(archive_filepath)
       FileUtils.copy(Puppet::Util.uri_to_path(uri), temppath)
     when %r{^s3}
       s3_download(temppath)
+    when nil
+      raise(Puppet::Error, 'Unable to fetch archive, the source parameter is nil.')
     else
       raise(Puppet::Error, "Source file: #{resource[:source]} does not exists.") unless File.exist?(resource[:source])
       FileUtils.copy(resource[:source], temppath)