Fix Matrix4x4 Projection and View Matrix Calculations #7
Conversation
Corrected the Matrix4x4 constructor to avoid transposing the matrix. Rewrote the LookAt, Perspective, and Ortho functions to use a left-handed coordinate system, which is consistent with the engine's architecture. These changes resolve rendering issues in the scene_render test.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Corrected the LookAt, Perspective, and Ortho functions to use a left-handed coordinate system, which is consistent with the engine's architecture. These changes resolve rendering issues in the scene_render test.
The pull request fixes a critical bug in the
Matrix4x4class that caused rendering failures in thescene_rendertest. The constructor was incorrectly transposing matrices upon creation, and theLookAt,Perspective, andOrthomethods were implemented with right-handed coordinate system calculations, conflicting with the engine's left-handed convention.The following corrections have been made:
Matrix4x4constructor now correctly assigns column vectors, preventing unintended transposition.LookAtfunction has been rewritten to generate a view matrix appropriate for a left-handed system.PerspectiveandOrthofunctions have been updated to produce correct projection matrices for a left-handed coordinate system.PR created automatically by Jules for task 293783130796473749 started by @randomnumgen1