Skip to content

fix(lens): review output cites AGENTS.md Step 7, which does not exist in host projects #327

Description

@randomm

Context

extension/src/lens-review-format.ts:194 emits a user-facing line in the blocked-lens banner:

"... Re-dispatch dispatch_lens_review to retry, or surface this to the user for an override decision per AGENTS.md Step 7 doctrine."

"Step 7" is /work.md's internal step numbering. It is not a section of any AGENTS.md, and pi-ensemble runs primarily inside OTHER projects, whose AGENTS.md will certainly not contain it. The message directs users at documentation that does not exist.

Principle

pi-ensemble is a tool used inside other projects. Its core functionality must not depend on, or point at, content in a host project's AGENTS.md. That file's role is to describe the host project and its quality gates — it is not a place pi-ensemble can reference its own internal doctrine.

A full sweep of the prompt layer (agents-base/, modules/, pi-prompts/, manifests/, skill/) found ZERO violations of this principle — every reference there correctly treats AGENTS.md as the host project's conventions document. Only two violations existed in TypeScript. The other, inlineMergePrompt deciding the merge flag by asking an LLM to read prose, is fixed by #323. This is the remaining one.

Definition of Done

  • The banner no longer references AGENTS.md or any pi-ensemble-internal step numbering.
  • Replacement wording states the actual choice available to the user — retry the review, or override and proceed — without citing an external document.
  • A grep for AGENTS.md under extension/src/ returns only module-header jsdoc comments, no user-facing strings and no control-flow dependencies.

Effort

One line plus a test assertion. Genuinely small.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions