Repository navigation
Retry CLI invocations in test_cli_crypt.py that exit with an error or produce no output - #5962
Merged
Merged
Conversation
… produce no output
randombit
approved these changes
Sep 22, 2026
randombit
left a comment
randombit
left a comment
Owner
There was a problem hiding this comment.
I've also seen this a couple of times now. Hopefully a more permanent/reliable fix becomes possible once the issue is better understood, returncode will help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the
windows-11-armrunners moved to the Visual Studio 2026 image,test_cli_crypt.pyhas failed twice in 8 runs on that image (#5941 with MSVC 19.51 on a Serpent/XTS vector, then with clang-cl 22.1 on a ChaCha20Poly1305 vector): a single one of the 6566 CLI invocations returned empty output and nothing on stderr, whilebotan-testandtest_cli.pypassed in the same job. The script ignores the exit code, so a crash and a silent exit look the same in the log.This change runs an invocation a second time when the process exits with an error, or produces no output where some is expected, and logs a warning with the exit code (also in hex, for Windows NTSTATUS values) for every such attempt. Wrong output is never retried.