Repository navigation
Override find_cert_chain instead of the deprecated cert_chain in the TLS examples - #5960
Merged
randombit merged 1 commit intoSep 22, 2026
Merged
Conversation
moritzschmitt
marked this pull request as ready for review
September 22, 2026 05:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
windows-11-armrunners are being migrated to the Visual Studio 2026 image this week (actions/runner-images#14602). Its MSVC 19.51 emits C4996 when a class overrides a[[deprecated]]virtual function, and with--werror-modethe amalgamation build fails intls_client.cpp,tls_proxy.cppandtls_ssl_key_log_file.cpp, which overrideCredentials_Manager::cert_chain:Seen first on #5941, where the same tree passed with MSVC 19.44 a few hours earlier. The library and the tests are not affected because
BOTAN_IS_BEING_BUILTdisablesBOTAN_DEPRECATED.The three examples now override
find_cert_chaininstead, which is what the deprecation message asks for. Behaviour is unchanged; the newacceptable_CAsparameter is ignored like the others.