Repository navigation
Fix ML-KEM private key encoding - #5934
Open
falko-strenzke wants to merge 5 commits into
Open
falko-strenzke wants to merge 5 commits into
falko-strenzke wants to merge 5 commits into
Conversation
falko-strenzke
force-pushed
the
fix-mlkem-priv-key-encoding
branch
from
September 16, 2026 10:24
ddf10e3 to
99e07d3
Compare
falko-strenzke
force-pushed
the
fix-mlkem-priv-key-encoding
branch
from
September 21, 2026 14:41
99e07d3 to
0188697
Compare
Collaborator
Author
|
@randombit Since #5307 is scheduled for 3.14, it would make sense to include this one as well. Otherwise the interfaces to the ML-* will be awkwardly different. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow up to #5307, which it is based on, and which fixes the ML-KEM private key encoding in PKCS#8 files, which is currently incompliant to the RFC that defines ML-KEM in the X.509 context.
As a next step, once #5307 and this one here are merged, I plan to factor out more common code from ML-DSA and ML-KEM regarding the DER encoding and align the corresponding test cases.