Add support for Chrome >= 81 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tinchoz49 nice, i don't have time to review this, but can add you here if you wanna maintain this one more easily? |
|
oh thanks! that would work |
|
I think I invited you now |
|
@tinchoz49 do you have publish rights to npm? can add you there also |
|
No, I don't. That will be great too |
|
Hi @mafintosh, sorry to bother you, did you give me rights to npm? btw: thanks for your help to fix my hyperswarm issues yesterday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
random-access-chrome-file is broken in the latest Chrome (v81).
Related with: https://chromium.googlesource.com/chromium/src/+/5860af49be9d80a85aba59248849495ceff23c77
Every time we write/read from a file we need to have the updated file instance, this PR adds that functionality.
I tested the new version against the benchmark and it performs similar to the old one.