fix: terminal pane layout - ensure proper height propagation#24
Merged
fix: terminal pane layout - ensure proper height propagation#24
Conversation
The terminal pane was rendering with 0 height because of missing height constraints in the flex layout chain. Changes: - render_content: use size_full() instead of w_full() to provide height - All pane wrappers: add h_full() to stretch vertically in flex row - Terminal pane container: use size_full() instead of flex_1() - Remove overflow_hidden() from outer container (was collapsing height) - Add proper wrapper around terminal_pane with flex_1/min_h_0/overflow_hidden The issue was that using flex_1() with overflow_hidden() on the terminal pane container caused height to collapse to 0. Using size_full() and moving overflow_hidden() to an inner wrapper resolves this. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The terminal pane container used
flex_1()withoverflow_hidden()which caused the height to collapse to 0. The flex layout wasn't propagating height properly through the container hierarchy.Changes
render_content(): Changedw_full()tosize_full()to provide explicit heighth_full()to stretch vertically in the flex row containerflex_1()tosize_full()and removedoverflow_hidden()from outer containerterminal_panewithflex_1()/min_h_0()/overflow_hidden()to correctly contain terminal contentTest plan
🤖 Generated with Claude Code