feat(terminal): Sprint 2.3 URL recognition with hover state#21
Merged
feat(terminal): Sprint 2.3 URL recognition with hover state#21
Conversation
- Add hovered_url field to TerminalPane to cache navigation target state - Update handle_navigation_target to store URL on hover events - Show pointer cursor when hovering over clickable URLs - Display URL footer bar at bottom of terminal when hovering - Add regex pattern tests for path/URL recognition This completes Sprint 2.3 Phase 4 (Visual Hover Effects) by providing visual feedback when users hover over clickable URLs in the terminal. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
High severity fixes: - Add empty content guard to mouse handlers to prevent index panics - Move mouse handlers from pane root to terminal content element only (prevents tab bar interactions from triggering terminal mouse events) Medium severity fixes: - Focus terminal on mouse down to ensure modifier keys work correctly - Clear hover state when secondary modifier (Cmd/Ctrl) is released (uses modifiers.secondary() for cross-platform compatibility) Also refactored render_terminal_content to render_terminal_content_inner returning Stateful<Div> to allow chaining mouse handlers on the element. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
QA gate passed: 73/73 tests, clippy clean, all builds pass. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Resolve conflicts by integrating Sprint 2.3 hover state features with develop's TerminalElement improvements: - Keep hovered_url field and caching logic - Use TerminalElement for rendering (from develop) - Add hover footer overlay on TerminalElement container - Maintain modifier clearing in handle_mouse_move - Add regex pattern tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
randlee
added a commit
that referenced
this pull request
Jan 28, 2026
Sprint 2.3 (URL Recognition & Clicking) completed: - Hover state with visual feedback (pointer cursor + URL footer) - Mouse event handling with empty content guards - ARCH-CODEX review findings addressed - PR #21 merged Phase 2 now 100% complete. Ready for Phase 3 (File Browser). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Sprint 2.3 URL Recognition & Clicking feature:
Key Changes
Hover State (Phase 4)
Safety & UX Fixes
Test plan
cargo checkpassescargo buildpassescargo test- 73/73 tests passcargo clippy- clean🤖 Generated with Claude Code