feat: add resizable panes with draggable dividers#20
Merged
Conversation
- Add ResizeDragState and drag handling for pane dividers - Implement render_divider with 6px hitbox and col-resize cursor - Add flex_basis layout with configurable pane_ratios - Double-click divider to reset ratios to default (1:2:1) - Enforce MIN_PANE_WIDTH (150px) during resize - Ratios persist via existing debounced save mechanism Terminal hardening (ARCH-CODEX review fixes): - Add minimum-width guard (2 columns) to prevent alacritty crashes - Fix Alt+key handling to send ESC prefix for shell shortcuts - Remove unused terminal snapshot code (dead code cleanup) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Resizable Panes
ResizeDragStatestruct tracks drag operations (divider index, start position, ratios)render_divider()creates 6px hitbox with col-resize cursor and visual feedbackflex_basis(relative(ratio))layout replaces equalflex_1()sizingMIN_PANE_WIDTH(150px) enforced during resizeTerminal Hardening (ARCH-CODEX)
update_terminal_snapshot,build_lines_from_content, andrendered_linesFiles Changed
src/ui/workspace.rs- Main resizable panes implementationsrc/terminal/element.rs- Minimum-width guardsrc/terminal/pane.rs- Alt+key fix, dead code removalsrc/terminal/tab.rs- Remove unused fielddocs/design/resizable-panes.md- Design documentTest plan
cargo checkcargo clippy --all-targetscargo test(68 tests)🤖 Generated with Claude Code