Skip to content

Add update validation for User.UserName #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add update validation for User.UserName #943

wants to merge 2 commits into from
+81 −6

Conversation

JonCrowther
Copy link
Contributor

Issue:

Problem

UserName was immutable in Norman, but with public API we need a webhook to do that validation.

Solution

Added a new validation. It's possible to add a UserName if none existed, but not to change an existing one.

CheckList

  • Test
  • Docs

@JonCrowther JonCrowther self-assigned this Jun 10, 2025
@JonCrowther JonCrowther requested a review from a team as a code owner June 10, 2025 20:23
crobby
crobby approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobby crobby crobby approved these changes

@pmatseykanets pmatseykanets Awaiting requested review from pmatseykanets

Assignees

@JonCrowther JonCrowther

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonCrowther @crobby