🌱 [release/v0.7] Allow creation of fleetworkspace for existing namespace when annotation is present and set to true #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notation is present and set to true.
yiannistri
changed the title
alexander-demicev
approved these changes
Jun 9, 2025
|
@crobby when you get a chance, I would appreciate a review, thanks! |
|
@crobby can you please review ? |
crobby
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #932 to release/v0.7
This PR is part of a fix for rancher/turtles#1329
Problem
When a
fleetworkspacegets created, the webhook code in this repo also creates a corresponding namespace. This presents a problem when there is a need to create afleetworkspacefor an existing namespace as the webhook does not currently allow this. This PR adds an annotation that allows afleetworkspaceto be created for an existing namespace when this annotation is present.Solution
When a specific annotation is present and set to true for an existing namespace, then the webhook allows the creation of a
fleetworkspaceresource.CheckList