[v0.6] Populate backing namespace field for projects #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonCrowther
changed the title
nflynt
previously approved these changes
Oct 30, 2024
| @@ -4,6 +4,9 @@ | |||
|
|
|||
| ClusterName must be equal to the namespace, and must refer to an existing `management.cattle.io/v3.Cluster` object. In addition, users cannot update the field after creation. | |||
|
|
|||
| ### BackingNamespace validation | |||
| The BackingNamespace field cannot be changed once set. Projects without the BackingNamespace field can have it added. | |||
There was a problem hiding this comment.
Suggested change
| The BackingNamespace field cannot be changed once set. Projects without the BackingNamespace field can have it added. | |
| The `BackingNamespace` field cannot be changed once set. Projects without the `BackingNamespace` field can have it added. |
| @@ -31,4 +34,13 @@ If `field.cattle.io/no-creator-rbac` annotation is set, `field.cattle.io/creator | |||
|
|
|||
| ### On create | |||
|
|
|||
| Populates the BackingNamespace field by concatenating `Project.ClusterName` and `Project.Name`. | |||
There was a problem hiding this comment.
Suggested change
| Populates the BackingNamespace field by concatenating `Project.ClusterName` and `Project.Name`. | |
| Populates the `BackingNamespace` field by concatenating `Project.ClusterName` and `Project.Name`. |
| Populates the BackingNamespace field by concatenating `Project.ClusterName` and `Project.Name`. | ||
|
|
||
| If the project is using a generated name (ie `GenerateName` is not empty), the generation happens within the mutating webhook. | ||
| The reason for this is that the BackingNamespace is made up of the `Project.Name`, and name generation happens after mutating webhooks and before validating webhooks. |
There was a problem hiding this comment.
Suggested change
| The reason for this is that the BackingNamespace is made up of the `Project.Name`, and name generation happens after mutating webhooks and before validating webhooks. | |
| The reason for this is that the `BackingNamespace` is made up of the `Project.Name`, and name generation happens after mutating and before validating webhooks. |
|
|
||
| ### On update | ||
|
|
||
| If the BackingNamespace field is empty, populate the BackingNamespace field with the project name. |
There was a problem hiding this comment.
Suggested change
| If the BackingNamespace field is empty, populate the BackingNamespace field with the project name. | |
| If the `BackingNamespace` field is empty, it's populated with the project name. |
| backingNamespace = name.SafeConcatName(newProject.Spec.ClusterName, strings.ToLower(newProject.Name)) | ||
| _, err = m.namespaceClient.Get(backingNamespace, v1.GetOptions{}) | ||
| if err == nil { | ||
| return nil, fmt.Errorf("failed to create project: namespace %v already exists", backingNamespace) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("failed to create project: namespace %v already exists", backingNamespace) | |
| return nil, fmt.Errorf("failed to create project: namespace %s already exists", backingNamespace) |
There was a problem hiding this comment.
Q: Should we throw an error or just make it a no-op? 🤔
Comment on lines
161
to
163
| // updateProjectNamespace fills in BackingNamespace with the project name if it wasn't already set | ||
| // this was the naming convention of project namespaces prior to using the BackingNamespace field. Filling | ||
| // it here is just to maintain backwards compatibility |
There was a problem hiding this comment.
Suggested change
| // updateProjectNamespace fills in BackingNamespace with the project name if it wasn't already set | |
| // this was the naming convention of project namespaces prior to using the BackingNamespace field. Filling | |
| // it here is just to maintain backwards compatibility | |
| // updateProjectNamespace fills in BackingNamespace with the project name if it wasn't already set. | |
| // This was the naming convention for project namespaces prior to using the BackingNamespace field. | |
| // Filling it here is just to maintain backwards compatibility. |
nflynt
approved these changes
Oct 30, 2024
pmatseykanets
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Builds on rancher/rancher#47723