Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s 1.30 support #412

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

tomleb
Copy link
Contributor

@tomleb tomleb commented Jun 20, 2024

Issue: rancher/rancher#45331

Problem

We need 1.30 k8s support in webhook

Solution

  • Bumps all k8s.io libraries to 1.30
  • Move away from our fork of client-go because we no longer need it (the important changes were merged upstream)
  • Bump controller-runtime to 0.18.4 , same as rancher/rancher

CheckList

  • Test
  • Docs

@tomleb tomleb force-pushed the webhook-v0.5-k8s-1.30 branch 3 times, most recently from 9794cb7 to 40a2939 Compare June 26, 2024 14:29
@tomleb tomleb marked this pull request as ready for review June 27, 2024 03:04
@tomleb tomleb requested a review from a team as a code owner June 27, 2024 03:04
@tomleb tomleb changed the title WIP: Add k8s 1.30 support Add k8s 1.30 support Jun 27, 2024
Comment on lines +8 to +32
k8s.io/api => k8s.io/api v0.30.1
k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.30.1
k8s.io/apimachinery => k8s.io/apimachinery v0.30.1
k8s.io/apiserver => k8s.io/apiserver v0.30.1
k8s.io/cli-runtime => k8s.io/cli-runtime v0.30.1
k8s.io/client-go => k8s.io/client-go v0.30.1
k8s.io/cloud-provider => k8s.io/cloud-provider v0.30.1
k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.30.1
k8s.io/code-generator => k8s.io/code-generator v0.30.1
k8s.io/component-helpers => k8s.io/component-helpers v0.30.1
k8s.io/controller-manager => k8s.io/controller-manager v0.30.1
k8s.io/cri-api => k8s.io/cri-api v0.30.1
k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.30.1
k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.30.1
k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.30.1
k8s.io/kube-proxy => k8s.io/kube-proxy v0.30.1
k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.30.1
k8s.io/kubectl => k8s.io/kubectl v0.30.1
k8s.io/kubelet => k8s.io/kubelet v0.30.1
k8s.io/kubernetes => k8s.io/kubernetes v1.30.1
k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.30.1
k8s.io/metrics => k8s.io/metrics v0.30.1
k8s.io/mount-utils => k8s.io/mount-utils v0.30.1
k8s.io/pod-security-admission => k8s.io/pod-security-admission v0.30.1
k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.30.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the latest 1.30 version is now v0.30.2, perhaps we may want to bump modules to that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Rancher uses 0.30.1: rancher/rancher@f138213. I'd prefer we stay in step with Rancher, so let's keep 0.30.1.

go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 on bumping to the next minor version later

@tomleb tomleb merged commit 97679b8 into rancher:release/v0.5 Jun 28, 2024
1 check passed
@tomleb tomleb deleted the webhook-v0.5-k8s-1.30 branch June 28, 2024 13:23
@MbolotSuse MbolotSuse mentioned this pull request Jun 28, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants