Migrate webhook CI to GHA #394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes from the drone-based scripts: - Use different names for shell vars TAG and IMAGE_TAG - `HELM_VERSION` and `HELM_CHART_VERSION` are two different things (version of helm, and the version of the chart to generate) - `TAG` and `IMAGE_TAG` also denote different things - Can't use make from the GHA scripts: `dapper` doesn't pass on env vars
|
We're going to stick with the PR from the fork. Ignore this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to rancher/rancher#45231
This is a continuation of PR 383 -- we have to make a PR off the repo to access secrets
See #383 for previous comments.
Some changes from the drone-based scripts:
Use different names for shell vars TAG and IMAGE_TAG
HELM_VERSIONandHELM_CHART_VERSIONare two different things (version of helm, and the version of the chart to generate)TAGandIMAGE_TAGalso denote different thingsCan't use make from the GHA scripts:
dapperdoesn't pass on env vars