Bump to k8s 1.29 #366
Merged
Bump to k8s 1.29 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpromislow
force-pushed
the
45351-bump-to-k8s-1.29
branch
2 times, most recently
from
8434bc2
to
75659c5
Compare
ericpromislow
changed the title
ericpromislow
force-pushed
the
45351-bump-to-k8s-1.29
branch
from
d94787f
to
a98f58f
Compare
nflynt
reviewed
Jun 5, 2024
1 task
nflynt
previously approved these changes
Jun 12, 2024
ericpromislow
force-pushed
the
45351-bump-to-k8s-1.29
branch
from
761968a
to
899586b
Compare
|
|
ericpromislow
force-pushed
the
45351-bump-to-k8s-1.29
branch
from
899586b
to
1f7b267
Compare
Closed
nflynt
approved these changes
Jun 20, 2024
maxsokolovsky
approved these changes
Jun 20, 2024
Comment on lines
+3
to
+5
| go 1.22.0 | ||
|
|
||
| toolchain go1.22.1 |
There was a problem hiding this comment.
Is there any particular reason why we want a specific version of the toolchain?
In the case we want to keep the toolchain explicit should we try to use the latest toolchain? E.g. rancher/rancher currently uses go1.22.3 and toolchain go1.22.4 is already available.
There was a problem hiding this comment.
As discussed on Slack we'll merge as is and then revisit in a future PR that should follow pretty quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: rancher/rancher#45351