Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change codeowner to new team #342

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Change codeowner to new team #342

merged 1 commit into from
Mar 19, 2024

Conversation

JonCrowther
Copy link
Contributor

Issue: rancher/rancher#44840

Problem

The codeowner file references a group that was recently deleted and is no longer valid

Solution

Updated the codeowner to the new team name

@JonCrowther JonCrowther self-assigned this Mar 19, 2024
tomleb
tomleb approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those that want to verify the team name you can type @ followed by rancher/ and keep writing until you see the full team name.

@JonCrowther JonCrowther merged commit a8d4060 into rancher:release/v0.5 Mar 19, 2024
1 check passed
@JonCrowther JonCrowther deleted the update-codeowners-v.05 branch March 19, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomleb tomleb tomleb approved these changes

@nflynt nflynt nflynt approved these changes

@ericpromislow ericpromislow Awaiting requested review from ericpromislow

@maxsokolovsky maxsokolovsky Awaiting requested review from maxsokolovsky

Assignees

@JonCrowther JonCrowther

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonCrowther @tomleb @nflynt