Validate RoleTemplate as non-namespaced #332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This should fix the integration tests in rancher/rancher issue that was introduced in #328 (see also rancher/rancher#40584) which results in the following tests to fail:
The error looks like the following:
The issue is that namespaced resources cannot have
nonResourceURLs
in them. Thetrue
here is passed down to the upstream k8s validation function, which sees the nonResourceURLs in thecluster-owner
RoleTemplate.The fix simply uses the rules from non-namespaced resources, which skips the check for nonResourceURLs. Note this is not perfectly 1:1 with k8s but it's still more checks than we had previously.
@andreas-kupries As mentioned in Slack, feel free to take this as inspiration for a fix, or review it as is. Leaving as draft for now.