-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs #305
Update docs #305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch thanks for the update.
README.md
Outdated
@@ -12,7 +12,7 @@ API server and perform validation or mutation of resources prior to their persis | |||
the cluster database. | |||
The validation and mutation are performed by custom code whose logic is defined by the instance of an admission controller. | |||
Cluster administrators may create many such controllers that perform custom validation or mutation in series. | |||
The Rancher Webhook is one such controller that runs only in the local cluster. | |||
The Rancher Webhook is one such controller that runs both in local cluster and all downstream clusters by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't provide an option for people to use Rancher without the webhook.
The Rancher Webhook is one such controller that runs both in local cluster and all downstream clusters by default. | |
The Rancher Webhook is one such controller that runs both in local cluster and all downstream clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but I am blocking the merge until v2.8.0 is released.
Co-authored-by: Max Sokolovsky <genexpr@protonmail.com>
No description provided.