Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #305

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Update docs #305

merged 2 commits into from
Dec 19, 2023

Conversation

rohitsakala
Copy link
Member

No description provided.

@rohitsakala rohitsakala requested a review from a team October 25, 2023 14:46
Copy link
Contributor

@KevinJoiner KevinJoiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch thanks for the update.

README.md Outdated
@@ -12,7 +12,7 @@ API server and perform validation or mutation of resources prior to their persis
the cluster database.
The validation and mutation are performed by custom code whose logic is defined by the instance of an admission controller.
Cluster administrators may create many such controllers that perform custom validation or mutation in series.
The Rancher Webhook is one such controller that runs only in the local cluster.
The Rancher Webhook is one such controller that runs both in local cluster and all downstream clusters by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't provide an option for people to use Rancher without the webhook.

Suggested change
The Rancher Webhook is one such controller that runs both in local cluster and all downstream clusters by default.
The Rancher Webhook is one such controller that runs both in local cluster and all downstream clusters.

Copy link
Contributor

@KevinJoiner KevinJoiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I am blocking the merge until v2.8.0 is released.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Max Sokolovsky <genexpr@protonmail.com>
@KevinJoiner KevinJoiner merged commit 5c1fe0f into rancher:release/v0.4 Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants