Prevent CRTBs from being created with mismatching Namespace and ClusterName #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonCrowther
requested review from
cmurphy,
maxsokolovsky,
MbolotSuse and
a team
JonCrowther
force-pushed
the
fix-crtb-bugs
branch
from
4967f99
to
8fd02f7
Compare
cmurphy
reviewed
Sep 15, 2023
pkg/resources/management.cattle.io/v3/clusterroletemplatebinding/validator.go
Outdated
Show resolved
Hide resolved
cmurphy
previously approved these changes
Sep 15, 2023
MbolotSuse
previously approved these changes
Sep 15, 2023
maxsokolovsky
previously approved these changes
Sep 15, 2023
JonCrowther
dismissed stale reviews from maxsokolovsky, MbolotSuse, and cmurphy
via
bc81227
MbolotSuse
approved these changes
Sep 15, 2023
maxsokolovsky
approved these changes
Sep 15, 2023
cmurphy
approved these changes
Sep 15, 2023
rohitsakala
pushed a commit
to rohitsakala/webhook
that referenced
this pull request
Nov 1, 2023
…erName (rancher#294) * Fix 42754 * Update create error message to have consistent wording * Update CRTB docs * Address comments * Update integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#42754
Problem
Users can create CRTBs that have different namespaces and ClusterNames. That causes their deletion to fail when the cluster is deleted. It also doesn't appear in the UI as intended.
Solution
I also fixed the wording of one of the error messages to be more clear.
CheckList