feat: improve ux on auto/manual etcd snapshots #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
added
the
kind/enhancement
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
etcd-snapshot-improve-ux-on-manual-field
branch
from
0311d32
to
195f0a2
Compare
alexander-demicev
approved these changes
Oct 8, 2024
furkatgofurov7
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This simply modifies the way etcd snapshot controller classifies whether snapshots are manual or automatic. As automatic snapshots are taken care of by CAPRKE2 via
rke2ControlPlaneSpec.serverConfig.etcd.backupConfig, these are the resources that should be marked, which is done via annotationetcd.turtles.cattle.io/automatic-snapshotapplied on snapshot creation.When manual snapshots are supported, we can use the
manualfield added to the snapshot status.Which issue(s) this PR fixes:
Fixes #728
Special notes for your reviewer:
Checklist: