Sign published turtles manifest and all underlying images #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
changed the title
alexander-demicev
force-pushed
the
signimage
branch
2 times, most recently
from
03df172
to
214d644
Compare
furkatgofurov7
previously approved these changes
Sep 12, 2024
alexander-demicev
force-pushed
the
signimage
branch
from
214d644
to
00860f8
Compare
Danil-Grigorev
previously approved these changes
Sep 12, 2024
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
signimage
branch
from
00860f8
to
c4d9f22
Compare
Danil-Grigorev
approved these changes
Sep 13, 2024
furkatgofurov7
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a recursive signing of the published manifest. The manifest digest is saved in a temp file specified by
--iidfileflag, this is the only way to get the image digest without requesting it from the remote registry as buildx doesn't store anything locally.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: