Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LocalObjectReference usage with strings in exp/etcdrestore API #735

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Sep 9, 2024

What this PR does / why we need it:
Additionally, currently when running make build-chart & release-chart Makefile targets throw:

/Users/userX/repos/rancher-turtles/hack/tools/bin/helm-v3.15.3 package out/charts/rancher-turtles --app-version=est/v0.11.0 --version=est/v0.11.0 --destination=out/package
Error: Invalid Semantic Version
make: *** [build-chart] Error 1

error and that is because of how we construct HELM_CHART_TAG variable. In this patch, the extraction command was updated to use grep with a regular expression to ensure it extracts a valid semantic version (e.g., v0.11.0) and both helm package commands run as expected.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #729

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 added kind/refactor Indicates a PR with large refactoring changes e.g. removes files or moves content area/etcdsnapshot-restore Categorizes issue or PR as related to Turtles ETCD Snapshot & Restore feature labels Sep 9, 2024
@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner September 9, 2024 08:16
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@furkatgofurov7 furkatgofurov7 merged commit e7198cd into rancher:main Sep 16, 2024
30 checks passed
@furkatgofurov7 furkatgofurov7 deleted the change-lor-to-string branch September 16, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/etcdsnapshot-restore Categorizes issue or PR as related to Turtles ETCD Snapshot & Restore feature kind/refactor Indicates a PR with large refactoring changes e.g. removes files or moves content
Development

Successfully merging this pull request may close these issues.

Replace local object references with strings
3 participants