Replace LocalObjectReference usage with strings in exp/etcdrestore API #735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Additionally, currently when running
make build-chart & release-chart
Makefile targets throw:error and that is because of how we construct
HELM_CHART_TAG
variable. In this patch, the extraction command was updated to usegrep
with a regular expression to ensure it extracts a valid semantic version (e.g., v0.11.0) and both helm package commands run as expected.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #729
Special notes for your reviewer:
Checklist: