Skip to content

Conversation

@salasberryfin
Copy link
Contributor

@salasberryfin salasberryfin commented Apr 23, 2025

What this PR does / why we need it:

Bump CAAPF to v0.8.1.

Which issue(s) this PR fixes:
Fixes #1303

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Carlos Salas <carlos.salas@suse.com>
@Danil-Grigorev
Copy link
Contributor

Danil-Grigorev commented Apr 24, 2025

Thanks for opening this @salasberryfin. I forgot to mention - rancher/cluster-api-addon-provider-fleet#240 need to be included into addon config in order for HelmApp feature to be enabled. Would you be ok to add it or shall I push to the branch?

Basically it needs

    featureGates:
      configMap:               # ConfigMap state configuration settings (optional)
        ref:               
          kind: ConfigMap
          apiVersion: v1
          name: rancher-config
          namespace: cattle-system
      experimentalOciStorage: true   # Enables experimental OCI storage support
      experimentalHelmOps: true

in

apiVersion: addons.cluster.x-k8s.io/v1alpha1

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@salasberryfin salasberryfin marked this pull request as ready for review April 24, 2025 09:04
@salasberryfin salasberryfin requested a review from a team as a code owner April 24, 2025 09:04
@Danil-Grigorev
Copy link
Contributor

Danil-Grigorev commented Apr 24, 2025

Seems to be an issue with expectations on fleet key in configMap, it should be optional:

status:
  conditions:
  - lastTransitionTime: "2025-04-24T09:17:01Z"
    message: 'FleetAddonConfig reconcile error: Fleet chart patch error: FleetSettings
      read error: Error deserializing response: missing field `fleet` at line 1 column
      972'

I’ll prepare a fix for this.

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@Danil-Grigorev Danil-Grigorev changed the title chore: bump caapf to v0.8.0 chore: bump caapf to v0.8.1 Apr 24, 2025
@Danil-Grigorev Danil-Grigorev enabled auto-merge (squash) April 24, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fleet-addon-provider v0.8.0 release

4 participants