Skip to content

Migrate to SLE BCI images #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Conversation

thomasferrandiz
Copy link
Contributor

This PR removes the usage of alpine images and replaces them with SLE BCI images.

@pgonin
Copy link

pgonin commented Apr 12, 2022

poke @macedogm

@pgonin
Copy link

pgonin commented Apr 12, 2022

build fail because of no matching manifest for linux/arm/v7 in the manifest list entries
I don't think we need to keep building for arm v7

@macedogm
Copy link
Member

@pgonin I spoke with Caleb about armv7 and we don't need to build for this arch, so it's safe to remove it from the build pipeline. I had do to it also for some of the PRs that I opened. We need to build and ship only amd64, s390x and arm64.

@macedogm macedogm self-requested a review April 12, 2022 13:29
Copy link
Member

@macedogm macedogm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to remove the build step for armv7 from Drone, then LGTM.

We do not need to build for armv7 anymore
and there are no SLE BCI images available for it.
Copy link
Member

@macedogm macedogm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,12 +1,11 @@
# Install the all-in-one binary so we can copy our run-time images into the image
# which helps avoid pulling them when running e2e tests.
ARG ALPINE="library/alpine:3.14"
FROM ${ALPINE} AS k3s
ARG SLES="registry.suse.com/suse/sle15:15.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why SLES here instead of BCI? Unpacked on my system, the SLES image is 7 times larger than Alpine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact it looks like bci-base and sle15 images are identical.
If you check here, they have the same digest:
https://registry.suse.com/static/suse/sle15sp3/index.html
https://registry.suse.com/static/bci/bci-base/index.html

But I agree it is unfortunate that they are so large.

There are also bci-minimal and bci-micro images which are small but they are still in Tech Preview.
As I understand, @macedogm is preparing a proposal to use them with sidecars but I don't know if we can use that yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm discussing internally about which image to "standardize". I don't believe that we will follow with the idea of the sidecar, but actually with a mix of bci-micro and bci-base/sle15 (when really needed). Let's see how it'll progress.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registry.suse.com/suse/sle15:15.3 is sle-bci, not full SLES.

@dweomer
Copy link
Contributor

dweomer commented Apr 21, 2022

This is also a go version bump. In trying to see if the go.mod/go.sum would change with a go mod tidy I ran into:

$ go mod tidy
go: downloading github.com/docker/distribution v2.8.0+incompatible
verifying github.com/docker/distribution@v2.8.0+incompatible: checksum mismatch
        downloaded: h1:u9vuu6qqG7nN9a735Noed0ahoUm30iipVRlhgh72N0M=
        go.sum:     h1:l9EaZDICImO1ngI+uTifW+ZYvvz7fKISBAKpg+MbWbY=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

Fixed via #196

@dweomer dweomer merged commit 27ff123 into rancher:master Apr 25, 2022
coolguy1771 referenced this pull request in coolguy1771/home-ops Nov 17, 2022
….10.0 (#2097)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[rancher/system-upgrade-controller](https://togithub.com/rancher/system-upgrade-controller)
| | minor | `v0.9.1` -> `v0.10.0` |
|
[rancher/system-upgrade-controller](https://togithub.com/rancher/system-upgrade-controller)
| Kustomization | minor | `v0.9.1` -> `v0.10.0` |

---

### Release Notes

<details>
<summary>rancher/system-upgrade-controller</summary>

###
[`v0.10.0`](https://togithub.com/rancher/system-upgrade-controller/releases/tag/v0.10.0)

[Compare
Source](https://togithub.com/rancher/system-upgrade-controller/compare/v0.9.1...v0.10.0)

##### What's Changed

- Remove failure:ignore instruction in .drone.yml by
[@&#8203;Anarkis](https://togithub.com/Anarkis) in
[https://github.com/rancher/system-upgrade-controller/pull/190](https://togithub.com/rancher/system-upgrade-controller/pull/190)
- Bump golang.org/x/crypto by
[@&#8203;macedogm](https://togithub.com/macedogm) in
[https://github.com/rancher/system-upgrade-controller/pull/194](https://togithub.com/rancher/system-upgrade-controller/pull/194)
- fix for docker/distribution checksum mismatch by
[@&#8203;dweomer](https://togithub.com/dweomer) in
[https://github.com/rancher/system-upgrade-controller/pull/196](https://togithub.com/rancher/system-upgrade-controller/pull/196)
- Migrate to SLE BCI images by
[@&#8203;thomasferrandiz](https://togithub.com/thomasferrandiz) in
[https://github.com/rancher/system-upgrade-controller/pull/193](https://togithub.com/rancher/system-upgrade-controller/pull/193)
- Add Volume Mounts by
[@&#8203;luthermonson](https://togithub.com/luthermonson) in
[https://github.com/rancher/system-upgrade-controller/pull/195](https://togithub.com/rancher/system-upgrade-controller/pull/195)
- enable fossa scanning by
[@&#8203;paraglade](https://togithub.com/paraglade) in
[https://github.com/rancher/system-upgrade-controller/pull/192](https://togithub.com/rancher/system-upgrade-controller/pull/192)
- Fix drone by [@&#8203;brandond](https://togithub.com/brandond) in
[https://github.com/rancher/system-upgrade-controller/pull/211](https://togithub.com/rancher/system-upgrade-controller/pull/211)
- add columns to plan crd by
[@&#8203;Robbilie](https://togithub.com/Robbilie) in
[https://github.com/rancher/system-upgrade-controller/pull/210](https://togithub.com/rancher/system-upgrade-controller/pull/210)

##### New Contributors

- [@&#8203;Anarkis](https://togithub.com/Anarkis) made their first
contribution in
[https://github.com/rancher/system-upgrade-controller/pull/190](https://togithub.com/rancher/system-upgrade-controller/pull/190)
- [@&#8203;macedogm](https://togithub.com/macedogm) made their first
contribution in
[https://github.com/rancher/system-upgrade-controller/pull/194](https://togithub.com/rancher/system-upgrade-controller/pull/194)
- [@&#8203;paraglade](https://togithub.com/paraglade) made their first
contribution in
[https://github.com/rancher/system-upgrade-controller/pull/192](https://togithub.com/rancher/system-upgrade-controller/pull/192)
- [@&#8203;Robbilie](https://togithub.com/Robbilie) made their first
contribution in
[https://github.com/rancher/system-upgrade-controller/pull/210](https://togithub.com/rancher/system-upgrade-controller/pull/210)

**Full Changelog**:
rancher/system-upgrade-controller@v0.9.1...v0.10.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNi4yIiwidXBkYXRlZEluVmVyIjoiMzQuMjYuMiJ9-->

Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants