Add interlocks to ensure operations are not interrupted #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is applying a plan and does not start applying a plan when a restart is pending Signed-off-by: Chris Kim <oats87g@gmail.com>
Oats87
requested review from
jakefhyde,
HarrisonWAffel and
aiyengar2
as code owners
HarrisonWAffel
requested changes
Dec 11, 2023
Signed-off-by: Chris Kim <oats87g@gmail.com>
Signed-off-by: Chris Kim <oats87g@gmail.com>
Signed-off-by: Chris Kim <oats87g@gmail.com>
HarrisonWAffel
previously approved these changes
Dec 12, 2023
Signed-off-by: Chris Kim <oats87g@gmail.com>
Signed-off-by: Chris Kim <oats87g@gmail.com>
Signed-off-by: Chris Kim <oats87g@gmail.com>
Signed-off-by: Chris Kim <oats87g@gmail.com>
jakefhyde
previously approved these changes
Dec 12, 2023
HarrisonWAffel
approved these changes
Dec 12, 2023
jakefhyde
approved these changes
Dec 12, 2023
gb-123-git
added a commit
to gb-123-git/rancher-system-agent
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rancher/rancher#43658
This PR adds interlocks to the system-agent which are used to indicate whether the install script and applyinator should continue.
The first interlock
restart-pendingindicates to the system-agent that a restart is pending per the install script, and disallows the applyinator from starting to apply a plan when a restart is pending.The second interlock
applyinator-activeindicates to the install script that the applyinator is currently reconciling a plan and should not restart the system-agent.The
restart-pendinginterlock has a timeout feature built into the system-agent which allows the system-agent to ignore the pending restart after 5 minutes, which can be the case when the install script quits prematurely.