Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template link #269

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fix template link #269

merged 2 commits into from
Oct 18, 2024

Conversation

dereknola
Copy link
Member

  • Also add a link in etcd backup around mention of configuration file (community ask).

Linked Issue

#268

@dereknola
Fix template link
9eabf31 
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner October 17, 2024 17:29
@dereknola
Copy link
Member Author

@brandond I'm not sure what you want to say about the base template. If you want to provide a comment on this I will incorporate it.

@brandond
Copy link
Member

@dereknola just the same thing we say in the k3s docs would be good:
https://docs.k3s.io/advanced#base-template

@dereknola
Add note on base template
f0a33b6 
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola merged commit 6ac3e5e into rancher:main Oct 18, 2024
@dereknola dereknola deleted the link_nit branch November 4, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelbuil manuelbuil manuelbuil approved these changes

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereknola @brandond @manuelbuil